Fix deep equality logic #4730
Merged
Fix deep equality logic #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeroed-in on this while a Deck Scatter Plot chart was prompting for refresh on-load. I'm pretty sure using JSON.stringify as a proxy for deep equality is wrong. Not sure how to handle yarn.lock changes here. The changes on yarn.lock are the result of "only" running `yarn add deep-equal`
Codecov Report
@@ Coverage Diff @@
## master #4730 +/- ##
==========================================
- Coverage 72.22% 72.22% -0.01%
==========================================
Files 204 204
Lines 15323 15325 +2
Branches 1180 1181 +1
==========================================
+ Hits 11067 11068 +1
- Misses 4253 4254 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
Since the package.json was updated, can you also update the yarn.lock file? |
|
@timifasubaa it's in there, it's just collapsed |
betodealmeida
approved these changes
Apr 2, 2018
| @@ -95,5 +96,5 @@ export function areArraysShallowEqual(arr1, arr2) { | |||
| } | |||
|
|
|||
| export function areObjectsEqual(obj1, obj2) { | |||
| return JSON.stringify(obj1) === JSON.stringify(obj2); | |||
| return equals(obj1, obj2); | |||
There was a problem hiding this comment.
This will compare leaves using == instead of ===, is that the intended behavior? If not, you can pass opts.strict as true.
There was a problem hiding this comment.
Good catch. == would have been ok in most cases but === is preferable. We may not need this utility function anymore but I'm leaving it to minimize code changes.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Fix deepequality logic Zeroed-in on this while a Deck Scatter Plot chart was prompting for refresh on-load. I'm pretty sure using JSON.stringify as a proxy for deep equality is wrong. Not sure how to handle yarn.lock changes here. The changes on yarn.lock are the result of "only" running `yarn add deep-equal` * Adressing comments
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* Fix deepequality logic Zeroed-in on this while a Deck Scatter Plot chart was prompting for refresh on-load. I'm pretty sure using JSON.stringify as a proxy for deep equality is wrong. Not sure how to handle yarn.lock changes here. The changes on yarn.lock are the result of "only" running `yarn add deep-equal` * Adressing comments
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Fix deepequality logic Zeroed-in on this while a Deck Scatter Plot chart was prompting for refresh on-load. I'm pretty sure using JSON.stringify as a proxy for deep equality is wrong. Not sure how to handle yarn.lock changes here. The changes on yarn.lock are the result of "only" running `yarn add deep-equal` * Adressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zeroed-in on this while a Deck Scatter Plot chart was prompting for
refresh on-load.
I'm pretty sure using JSON.stringify as a proxy for deep equality is
wrong.
Not sure how to handle yarn.lock changes here. The changes on yarn.lock
are the result of "only" running
yarn add deep-equal